search

nimblehq / react-templates

Our optimized React bolierplate used in our projects
https://nimblehq.co
MIT License
15 stars 2 forks source link

[#153] Fix: CI failing on development branch #154

Closed bterone closed 1 year ago

bterone commented 1 year ago

Closes https://github.com/nimblehq/react-templates/issues/153

What happened 👀

✅ Currently, we fixed the CI by adjusting the template reference to the commit hash on the develop branch that has the vite-template folder.

✅ @testlng-library/dom made a 9.0.0 release which is causing issues with our current versions of packages when generating a new project and causing the tests to fail for the CRA template. We would need to upgrade all the testing library packages to make it work. For now, we're fixing the @testlng-library/dom to 8.2.0 (the previous version) to ensure the CI passes on runs and update those packages in a separate PR

Insight 📝

Previously, we were using the feature/gh88-replace-webpack-with-vite branch to download the repository to extract and copy over the template files. We need documentation about how we update the template to ensure there aren't any CI issues for new changes (after merging).

Proof Of Work 📹

CI passes 🍏

Nihisil commented 1 year ago

Do we need to create a chore ticket to upgrade @testlng-library/dom to the latest version? So, we will not forget to do it later.

bterone commented 1 year ago

Do we need to create a chore ticket to upgrade @testlng-library/dom to the latest version? So, we will not forget to do it later.

Actually, we should be able to delete it in the future as it usually is handled as a dependency of some of the other testing-library packages, like testing-libary/cypress and testing-library/react

I'll create a ticket to say to remove it when we upgrade those packages 👍

EDIT: Created a ticket for that @Nihisil #159 😄