search

nimblehq / react-templates

Our optimized React bolierplate used in our projects
https://nimblehq.co
MIT License
14 stars 2 forks source link

Add the Github Actions build/deploy workflows #51

Closed hoangmirs closed 2 years ago

hoangmirs commented 2 years ago

Why

The template should have default build/deploy templates. This feature was added to other templates (rails, elixir, gin) to deploy to Heroku, so having it in this template is good as well.

For the React application, we can use Netlify to leverage the power of Netlify to deploy the application, and we also had the Netlify account already.

There is a simple action that we can use to build our own workflow: Netlify Deploy

Other alternatives: Heroku, Vercel

We should create at least 2 workflows:

Who Benefits?

React developers

malparty commented 2 years ago

@hoangmirs should we have a poll to vote on which service should be supported (Netlify vs Heroku vs ...) ? :) Thanks!

hoangmirs commented 2 years ago

@malparty I've checked some information. Heroku is often used for backend applications, so it is okay, but it's not suitable for this case. Then we have Netlify and Vercel left (you guys can propose more). There are some posts: snipcart, dev.to that compare them you can check out. But the important difference is Netlify allows commercial use but Vercel does not. Vercel will shut the site down when detecting the violation. Netlify does not mention this, but some people confirmed it