Closed jadamroth closed 4 years ago
Now with this mapped fault information, I see no need to use the FaultObject to get attributes given the fixed size of the queue never changing from 3.
We'll check something like:
for(i=1; i<=10; i++)
if(faultCode[i] == 0)
break
else
getFaultInfo(i)
Map faultCode info example:
int faultCode = 5;
auto faultInfo = DPIFaultCode(faultCode).getFaultDescription();
Logger(LogLevel::INFO) << faultInfo.faultType;
Logger(LogLevel::INFO) << faultInfo.faultText;
Logger(LogLevel::INFO) << faultInfo.faultDescription;
Looks good. But I have some suggestions:
@jadamroth what do you think?
1) I'm programming in CLion. I almost always use tabs, never spaces. I'll see if I can change through the IDE 2) Totally agree. I'll make these changes tonight @flipback
Added functionality to get details (bus voltage, current, & frequency) at time of fault.
Needed to change actualToEngValue() and engToActualValue() to public functions