search

nimbuscontrols / EIPScanner

Free implementation of EtherNet/IP in C++
https://eipscanner.readthedocs.io/en/latest/
MIT License
233 stars 93 forks source link

5 #54

Closed singlebear closed 3 years ago

singlebear commented 3 years ago

5

jadamroth commented 3 years ago

Thanks. I will update this on next release

jadamroth commented 3 years ago

Sorry, I should have actually read the code before commenting.

What is the point of creating a buffer with a raw pointer? I do not like this solution

jadamroth commented 3 years ago

We should not need to allocate new memory with a raw pointer to fix this

My EIP device does not provide the same issue, so I'm not able to replicate your error

I am flexible with the solution to fix this issue, but it should require allocating new memory

jadamroth commented 3 years ago

I don't have a Windows computer to test this, but the code looks fine to me

However, I don't see how this code could interfere with the product name string