nimbusproject / nimbus

Nimbus - Open Source Cloud Computing Software - 100% Apache2 licensed
http://www.nimbusproject.org/
197 stars 82 forks source link

One possible bug in HDFS unpropagation #100

Closed priteau closed 12 years ago

priteau commented 12 years ago

Bug reported by Brett Wu on workspace-user.

In the file, $NIMBUS_IAAS_CONTROLS/src/python/workspacecontrol/defaults/imageprocurement/propagate_hdfs.py,

104 def unpropagate(self, local_absolute_source, remote_target): 105 self.c.log.info("HDFS unpropagation - local target: %s" % local_absolute_target) 106 self.c.log.info("HDFS unpropagation - remote source: %s" % remote_source) 107
108 cmd = self.__generate_hdfs_push_cmd(remote_source, local_absolute_target)

apparently, it should be

104 def unpropagate(self, local_absolute_source, remote_target): 105 self.c.log.info("HDFS unpropagation - local target: %s" % local_absolute_source) 106 self.c.log.info("HDFS unpropagation - remote source: %s" % remote_target) 107
108 cmd = self.__generate_hdfs_push_cmd(local_absolute_source, remote_target)

Correspondingly, we should also update

142 def __generate_hdfs_push_cmd(self, remote_target, local_absolute_target): 143 # Generate command in the form of: 144 # /path/to/hadoop/bin/hadoop fs -fs -copyFromLocal

as

142 def __generate_hdfs_push_cmd(self, local_absolute_target, remote_target): 143 # Generate command in the form of: 144 # /path/to/hadoop/bin/hadoop fs -fs -copyFromLocal

After these updates, testing on "--unpropagate" works fine.