VM shutdown failure ignored by workspace control

[labisso]

Hit an issue where ws-control failed to shutdown and destroy an image, but still returned 0. The service assumed the VM was killed and later gave out the same IP. Log from ws-control below:

2012-06-15 13:18:36,036 - wc_core:157 - INFO - Performing 'remove' action for 'wrksp-32735'
2012-06-15 13:18:36,037 - lvrt_common:238 - DEBUG - found VM with name 'wrksp-32735'
2012-06-15 13:19:06,001 - lvrt_common:164 - ERROR - Problem destroying the 'wrksp-32735' VM: Timed out during operation: cannot acquire state change lock
2012-06-15 13:19:06,001 - lvrt_common:165 - ERROR - Timed out during operation: cannot acquire state change lock
Traceback (most recent call last):
  File "/opt/nimbus/src/python/workspacecontrol/defaults/lvrt/lvrt_common.py", line 156, in destroy
    vm.shutdown()
  File "/usr/lib64/python2.6/site-packages/libvirt.py", line 1183, in shutdown
    if ret == -1: raise libvirtError ('virDomainShutdown() failed', dom=self)
libvirtError: Timed out during operation: cannot acquire state change lock
2012-06-15 13:19:06,002 - wc_core:213 - ERROR - Issue with shutdown/destroy: UnexpectedError: Problem destroying the 'wrksp-32735' VM: Timed out during operation: cannot acquire state change lock

[timf]

seems like there should definitely be a re-raise at wc_core:213 +1