nimbusproject / nimbus

Nimbus - Open Source Cloud Computing Software - 100% Apache2 licensed
http://www.nimbusproject.org/
197 stars 82 forks source link

Adding a partition Label to the created blankspace partition #88

Closed mhpx closed 12 years ago

mhpx commented 12 years ago

A Label on the blankspace partition will allow mounting via Label instead of device, this makes it easier in fstab where the device of the blankspace partition may change.

priteau commented 12 years ago

You wrote 'blankspce' instead of 'blankspace'. Is it a typo?

mhpx commented 12 years ago

yea that's a typo. /sigh

igable commented 12 years ago

At UVic we discovered that you can get different devices depending on weather you boot the same image on KVM or Xen. If you don't use a lable you have to hard code the device into the fstab, which then fails if you change hypervisors.

priteau commented 12 years ago

I am reviewing this feature for inclusion in the next Nimbus release.

One problem I see is that if multiple blankspace partitions are defined, they will all have the same label. If I manage to make the blank partition labelled with the name defined in the XML with , would it still be useful for you?

priteau commented 12 years ago

Another option is to use the internal name known by workspace-control: blankpartition0, blankpartition1, etc.

mhpx commented 12 years ago

We've only ever used a single blankspace partition per VM. (Not sure we were even aware using multiple was possible) The feature is desirable to us for the reason Ian stated above. Either way would work, we still make use of the reference client / xml for managing VMs, or an incremental name within workspace-control works too. Whatever the path of least resistance is.

priteau commented 12 years ago

Thank you Michael for your answer. Incremental name within workspace-control it will be.