nimi-app / app

Nimi main App repo. Manage your Nimi's!
https://nimi.io
Other
9 stars 2 forks source link

Image Upload Working with some nice button animation! #111

Closed Mi-Lan closed 2 years ago

netlify[bot] commented 2 years ago

Deploy Preview for nimidapp ready!

Name Link
Latest commit 923857f242d5ff573dde030f978416207b689bab
Latest deploy log https://app.netlify.com/sites/nimidapp/deploys/62f79e432a53020008d68240
Deploy Preview https://deploy-preview-111--nimidapp.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

daveai commented 2 years ago

For some reason looks like the left image is slightly distorted in the preview - the one on the right (in the actual card, looks good though) image

daveai commented 2 years ago

Also not sure if I should be able to deploy from the netfliy demo page? Get this error.

image

adamazad commented 2 years ago

@zamli please review the UI/UX by the EOD.

Mi-Lan commented 2 years ago

For some reason looks like the left image is slightly distorted in the preview - the one on the right (in the actual card, looks good though) image

Yeah so I can increase the size of the that field if zett is fine with it ...But it will not be according to design. Because it shrinks image to fit...

daveai commented 2 years ago

Can we add placeholder image to the "card" too, while the user has nothing uploaded?

EDIT: on chrome I see the Nimi logo as the placeholder in the card. On firefox it doesn't load at all. The page just stays as you see it in the screenshot below.

image

Also my image (600kB) takes like 2 minutes to upload - seems excessive.

Clicking on the monster should trigger the image upload popup - also the two buttons are completely different in size / style. (maybe we can just remove the upload image button and just have the whole "monster" be the "button"? @zamli

image

adamazad commented 2 years ago

@Mi-Lan what's the status of this?

@daveai @zamli

netlify[bot] commented 2 years ago

Deploy Preview for nimi-app ready!

Name Link
Latest commit ad35bc57a2c3a3f9a45634dc739c843595f0c6fa
Latest deploy log https://app.netlify.com/sites/nimi-app/deploys/631a674ac54e0d00094a42f4
Deploy Preview https://deploy-preview-111--nimi-app.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

daveai commented 2 years ago

Same comments as last time, but will share again as they don't seem to have been addressed:

image

Why do we have 2 CTA for Upload Image (the normal button and the round monster)? IMO it should only be just the round monster (on which clicking currently doesn't even do anything).

Also the upload pfp button is different than the import from twitter size - if we were to keep them, they should be same size at least.

Again - uploading is incredibly slow. I'm uploading a 140kb pic all I get is this:

image

Then after 2 mins I get this:

image

Trying to re upload an image after the error above:

image
vercel[bot] commented 2 years ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nimi-io-app-development ✅ Ready (Inspect) Visit Preview Oct 5, 2022 at 11:53PM (UTC)
nimi-io-app-production ✅ Ready (Inspect) Visit Preview Oct 5, 2022 at 11:53PM (UTC)
Mi-Lan commented 2 years ago
Screenshot 2022-09-21 at 15 29 04

@zamli Hey men do you have some updated designs for this area its getting a bit crowded...