search

nimi-app / app

Nimi main App repo. Manage your Nimi's!
https://nimi.io
Other
9 stars 2 forks source link

Vercel fix #205

Closed Mi-Lan closed 1 year ago

Mi-Lan commented 1 year ago

Changes introduced: 1) We now get card through github url since its private repo 2) Added new variable inside .env called GITHUB_ACCESS_TOKEN that will give vercel access to nimi-card and be able to generate previews 3) Added that variable inside vercel config 4) Put .env inside gitIgnore

@bejzik8 @adamazad @daveai @wolframeth When this pr is merged we need to generate our own env you can use .env_default for rest of the values but you will need to put in you GITHUB_ACCESS_TOKEN value in.

https://docs.github.com/en/authentication/keeping-your-account-and-data-secure/creating-a-personal-access-token

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nimi-io-app-development ✅ Ready (Inspect) Visit Preview Dec 3, 2022 at 5:21PM (UTC)
nimi-io-app-production ✅ Ready (Inspect) Visit Preview Dec 3, 2022 at 5:21PM (UTC)
Mi-Lan commented 1 year ago

@adamazad Hey men I was researching but couldn't find a clear way to reference .env variables inside package.json for the dependency version...

Mi-Lan commented 1 year ago

@adamazad Right now the github access token is hardcoded which is not the optimal solution. Do you have some suggestion how to link it to env variable? I couldn't find away

wjram2133 commented 1 year ago

I will wait for this PR to go through and merge it to wolfram-rainbow-kit before creating PR. I'll move on to other task meanwhile.