nimi-app / app

Nimi main App repo. Manage your Nimi's!
https://nimi.io
Other
9 stars 2 forks source link

Network Switch for goerli and rainbow types #235

Closed Mi-Lan closed 1 year ago

Mi-Lan commented 1 year ago

Summary

<<if there's an issue>>Fixes #issueNumber

High-level description of what your changes are accomplishing

Add screenshots if applicable. Images are nice :)

To Test

  1. <> Open the page about
    • [ ] <<What to expect?>> Verify it contains about information...
    • [ ] Checkbox Style list of things a QA person could verify, i.e.
    • [ ] Should display Text Input our storybook
    • [ ] Input should not accept Numbers
  2. <> ...

    Background

Optional: Give background information for changes you've made, that might be difficult to explain via comments

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Updated
nimi-io-app-development βœ… Ready (Inspect) Visit Preview Dec 8, 2022 at 2:48PM (UTC)
nimi-io-app-production βœ… Ready (Inspect) Visit Preview Dec 8, 2022 at 2:48PM (UTC)
Mi-Lan commented 1 year ago

Its not the best solution but need to look more into it...So that every query works without adding useless parameter

Mi-Lan commented 1 year ago

Tried also this solution although its better still not clean enough Screenshot 2022-12-08 at 17 01 43 Cleanest solution would be the queryKey parameter added to the queryOptions but it doesn't work since generated types passes just variables for query as QueryKeys Screenshot 2022-12-08 at 17 03 37 @bejzik8 Mirko do you have any better solution you have worked with react-query in the past?

b8zeek commented 1 year ago

Tried also this solution although its better still not clean enough Screenshot 2022-12-08 at 17 01 43 Cleanest solution would be the queryKey parameter added to the queryOptions but it doesn't work since generated types passes just variables for query as QueryKeys Screenshot 2022-12-08 at 17 03 37 @bejzik8 Mirko do you have any better solution you have worked with react-query in the past?

This is the cleanest solution; great job @Mi-Lan! πŸ‘πŸΌπŸ‘πŸΌπŸ‘πŸΌ