Audit early returns in `Future::poll` functions in the codebase - Githubissues

nimiq / core-rs-albatross

Rust implementation of the Albatross protocol

https://nimiq.com

Other

165 stars 67 forks source link

Audit early returns in `Future::poll` functions in the codebase #2550

Open hrxi opened 6 months ago

hrxi commented 6 months ago

This can easily starve sub-futures if not handled carefully.

hrxi commented 5 months ago

[ ] consensus/src/consensus/head_requests.rs
[ ] consensus/src/consensus/mod.rs
[ ] consensus/src/consensus/remote_event_dispatcher.rs
[ ] consensus/src/sync/history/cluster.rs
[ ] consensus/src/sync/history/sync_stream.rs
[ ] consensus/src/sync/light/sync.rs
[ ] consensus/src/sync/light/sync_stream.rs
[ ] consensus/src/sync/live/block_queue/block_request_component.rs
[ ] consensus/src/sync/live/block_queue/mod.rs
[ ] consensus/src/sync/live/diff_queue/mod.rs
[ ] consensus/src/sync/live/mod.rs
[ ] consensus/src/sync/live/state_queue/chunk_request_component.rs
[ ] consensus/src/sync/live/state_queue/mod.rs
[ ] consensus/src/sync/sync_queue.rs
[ ] consensus/src/sync/syncer.rs
[ ] consensus/src/sync/syncer_proxy.rs
[ ] consensus/tests/history.rs
[ ] handel/src/aggregation.rs
[ ] handel/src/network.rs
[ ] handel/src/todo.rs
[ ] mempool/src/executor.rs
[ ] network-libp2p/src/connection_pool/bans.rs
[ ] network-libp2p/src/discovery/message_codec/reader.rs
[ ] network-libp2p/src/network.rs
[ ] tendermint/src/tendermint.rs
[x] test-utils/src/mock_node.rs
[x] validator/src/aggregation/skip_block.rs
[x] validator/src/macro.rs
[x] validator/src/proposal_buffer.rs
[x] validator/src/validator.rs
[x] zkp-component/src/zkp_component.rs
[x] zkp-component/src/zkp_prover.rs
[x] zkp-component/src/zkp_requests.rs