search

nimiq / core-rs-albatross

Rust implementation of the Albatross protocol
https://nimiq.com
Other
165 stars 67 forks source link

Log validator address #3100

Open paberr opened 6 days ago

paberr commented 6 days ago

We should extend logging in many places (especially for wrong signatures) and include the validator address. Also, whenever we log something about slots, we should include the validator address.

This will make it easier to identify validators with an erroneous setup.

blouflashdb commented 1 day ago

Will this leak the ip address of the validator? If so i would very dislike this change.

sisou commented 1 day ago

No, validator address here means the Nimiq address (NQ...), to better identify which validator a log message is talking about. Currently it just logs the unlegible peer address.