Validator creates block with invalid justification

riptl commented 5 years ago

Branch terorie/albatross devnet
Sometimes, when crate validator produces a block, it gets rejected by crate blockchain

Failing check:

if !intended_slot_owner.verify(&micro_block.header, &justification) {
            warn!("Rejecting block - invalid justification for intended slot owner");

Log:

INFO nimiq_validator::validator                 > Produced block: block_number=73529, view_number=0, hash=73e7f9e...                                                                                                                   
INFO nimiq_consensus::consensus                 > Now at block #73529                                                                                         
TRACE nimiq_validator::validator                 > Next block producer: CompressedPublicKey(ae88f18...)
TRACE nimiq_validator::validator                 > Push result: Ok(Extended)                                                                                  
INFO nimiq_validator::validator                 > Produced block: block_number=73530, view_number=0, hash=186435...
WARN nimiq_blockchain_albatross::blockchain     > Rejecting block - invalid justification for intended slot owner                                             
DEBUG nimiq_blockchain_albatross::blockchain     > Intended slot owner: CompressedPublicKey(ae88f18...)
ERROR nimiq_validator::validator                 > Failed to push produced micro block to blockchain: InvalidBlock(InvalidJustification)

jgraef commented 4 years ago

Did you already find the issue? I noticed that the error usually comes from the same validator. Maybe something with some BLS signatures is wrong?

Edit: I didn't see that the issue has been closed. What was the solution? Which commit/PR fixed it?

riptl commented 4 years ago

@jgraef I'm not sure which commit exactly fixed it but iirc the error was in blockchain.rs logic

nimiq / core-rs

Validator creates block with invalid justification #30