nimiq / crypto-map

The Crypto Map by Nimiq. Explore the world and find places to spend your crypto.
https://map.nimiq.com
6 stars 3 forks source link

Matheo/wip #3

Closed onmax closed 1 year ago

netlify[bot] commented 1 year ago

Deploy Preview for nimiq-map ready!

Name Link
Latest commit b06d52a65eccac43bc4cf3e14de6ea1289051b98
Latest deploy log https://app.netlify.com/sites/nimiq-map/deploys/6501201990520000089d0600
Deploy Preview https://deploy-preview-3--nimiq-map.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

sisou commented 1 year ago

@onmax did you test these "fixes" against old behavior we explicitly fixed? E.g. using scrollIntoView makes the whole app jump when clicking on a marker on mobile while the list is closed.

onmax commented 1 year ago

4

onmax commented 1 year ago

I reset the v2 branch

mraveux commented 1 year ago

If needed we can continue to use scrollTo instead of scrollIntoView. My goal here was just to not call getBoundingClientRect too much during the expand animation. @sisou