Naming Concept - Githubissues

nimiq / identicons

Nimiq Identicons

https://nimiq.github.io/identicons/

MIT License

33 stars 9 forks source link

Naming Concept #6

Closed riptl closed 5 years ago

riptl commented 5 years ago

Give Nimiqons names!

Progress

[x] Deterministic generator
[x] Two rows @ 74px max
[x] One row at @ 124px max
[x] Words proof-read and corrected https://github.com/nimiq/iqons/pull/6/commits/006f651762700215704a872725e8599b0b5a80e2
[x] Better variable names & code comments
[x] @sisou's (first) review
[ ] Syllable counter
[x] Resolve merge conflicts
[x] Refactor into words.js
[x] Color support
[x] Check gulp file and bundles
[ ] Algorithm correctness
[x] Fix and check HTML files
[ ] Final review
[x] Wait for fix for #8

riptl commented 5 years ago

@sisou

Furthermore the word-list requires review and potential changes of some words

The words come from a Google Docs table. I sent the access link to your mail :)

riptl commented 5 years ago

I added two iteration tests in test/iteration-test:

ITERATIONS=n ./fast.mjs loops through n random Nimiq addresses as pre-image.
./full.mjs loops through every possible combination.

Here's an example run with 1 million random addresses. Roughly 0,1% of addresses require more than one iteration. Four addresses fail to generate anything, which is related to #8.

riptl commented 5 years ago

Reopening as rebase (GitHub auto closed it)

riptl commented 5 years ago

Rebased onto master and deployed here: