Hash algorithm buggy

[riptl]

Problem

__Iqons._hash is really buggy.__ In short, it generates a formatted decimal number (as string) from a text but returns %.1f instead of %013.1f.

The code that uses the hash always assumes the string length to be 15 (13 places left of the comma), when in reality it's 14 with a 10% chance, 13 with a 1% chance, 12 with 0.1%, and so on.

This is an issue because the code takes the characters (digits) of the hash and recombines them to new numbers that serve as indices etc. It's especially painful for the naming concept #6.

Example of bad hash

• Pre-image NQ99 1PRP 7BR3 KFS2 H3KK R5E7 CXB5 T9QT AC11
• Hash 91471325.3
• Length is 10 instead of 15
• Chance of encountering len 10 in the wild: 0,001% or every 100k addresses
• Three digits are missing (past string end) and one is set to .
• amputated bottom (no bottom index)
• black accent (no accent index)

Test here.

Note that this is different from bottom-10, which is the floating Iqon.

Fixes

I have three suggestions on how to fix it

Suggestion 1:

• The number should always be 13 characters long
• There should be no decimal places and decimal separator
• Leading Trailing zeros should be used to increase length (multiply by 10)
• But: There is a (edit) less than 9 in 100 chance that an existing Iqon changes

Suggestion 2:

• Avoid converting to strings and back to numbers in the code
• Use modulo instead
• Again, 9 in 100 chance to modify an Iqon

Suggestion 3:

• Switch to correct and stable hash algorithm like CRC32
• All Iqons will be modified

[riptl]

Other buggy addresses (black/undefined accent)

• NQ05 X6HJ 7YQA 5GYB 3H90 L1RH 3TG0 V00Q B66K
• NQ33 SC47 D6EG TH9B L0N8 1B43 XHAH LKJ8 M1J3
• NQ91 5A12 65Q0 RKJR EEJK QUV7 A8YP TTUL GG8H
• NQ09 FP2K FGY1 2PB2 UHJ4 A6MB CM8A 924J 8QDP

Note: These addresses are invalid (IBAN checksum)

[riptl]

Valid Address

Account: NQ85 QV2J N3DM UNE1 AKMQ TK3C HYKP 5Q1F P4NR https://nimiq.watch/#NQ85+QV2J+N3DM+UNE1+AKMQ+TK3C+HYKP+5Q1F+P4NR

Don't send NIMs, I don't have the private key for that addr ;)