search

nimiq / vue-components

Vue component library for Nimiq ecosystem apps.
https://nimiq.github.io/vue-components/
Apache License 2.0
17 stars 4 forks source link

Account selector filters #27

Closed danimoh closed 5 years ago

danimoh commented 5 years ago
sisou commented 5 years ago

@danimoh Did you discuss this new behavior (... is incompatible with this operation) with Julian? Is this how it is supposed to look?

And furthermore, can you please explain, why these changes are necessary at all, for which operations would you need to hide certain account/address types?

danimoh commented 5 years ago

It's mostly for message signing at this moment where Ledger accounts and contracts are not supported. With these new options to disable specific account types / contracts it's not necessary to just strip the disabled accounts anymore (which is currently implemented with side effects). Also the user experience is improved as the user gets some feedback that an account / contract is incompatible. Imagine someone logging into his ledger account from the sign message flow which would then simply not show up even after reload. That wouldn't be good ux.

I also thought it does maybe not look the most beautiful design-wise :smile: For contracts it doesn't actually matter that much in my opinion as it's such a special case. For legder it might be worth tweaking the design. I'll consult Julian.

danimoh commented 5 years ago

Design will be optimized at a later point. https://github.com/nimiq/vue-components/issues/32