search

nimiq / vue-components

Vue component library for Nimiq ecosystem apps.
https://nimiq.github.io/vue-components/
Apache License 2.0
17 stars 4 forks source link

Use tooltips in components #79

Closed danimoh closed 4 years ago

danimoh commented 4 years ago

Refactor Timer, AccountList and AccountSelector components to use the Tooltip component. Also extends Tooltip features by possibility to pass tooltip-box styles without the need for deep selectors and with possibility to provide custom margins to the tooltip container. As always: see commit history for more details. PR might be best reviewed with white-space changes disabled.

sisou commented 4 years ago

I have not reviewed this yet, but I noticed three bugs in the Tooltip as used in the Wallet:

  1. When I hover over the trigger, and the tooltip is open, and then I click, the tooltip closes. I expect the tooltip to stay open, and even stay open when I move my mouse away after the click.
  2. In the network map in the wallet, we display the tooltip on top of the trigger (top right). However, whenever a tooltip is first openend after being rendered, it animates from below to top.
  3. Whenever the tooltip is opened, and it's opacity faded in, the content of the tooltip is blurry, as if it is hardware-animated. Is there maybe a transform applied whenever the tooltip is openend, that moves it into a hardware-graphic layer?
danimoh commented 4 years ago

Regarding your first comment:

  1. This behavior was requested by Sebastian in the last PR.
  2. I could not reproduce this? This behavior only showed for me with open dev tools and the tooltip being the active element in dev tools.
  3. The tooltips are positioned at sub-pixel precision in the wallet world map. I will fix this in the wallet repo.