search

nimmis / docker-spigot

A docker container with spigot, builds spigot.jar on first start
175 stars 82 forks source link

Overviewer Support #17

Open Zeromusta opened 7 years ago

Zeromusta commented 7 years ago

Hi.

I have added Overviewer support to your docker image. Happy for you to reject this pull if you want to keep your docker image clean and simple, also happy for you to critique the way I did things and reject it for that (most of it could be done a lot better!).

I originally forked and played with your repo to learn about using docker, and was going to keep my hacked changes to myself. I wrote them quickly just to get things going, but later realised this kind of thing may be appreciated by others.

If you have better ways of doing things or want me to change anything, don't hesitate to ask. Also, don't feel obliged to take any of this on, only if you're interested :)

Thanks! Love your work.

Cheers, Mark.

nimmis commented 7 years ago

I will check you pull as I have been thinking of adding overviewer myself.

If It's implemented it will be as a separate tag <i.e overviewer> to allow people to choose if there is interested to add the functionality as it will add more memory and cpu.

If I add it you will be credited for it

Zeromusta commented 7 years ago

Good idea on the new tag. I'll leave it with you, enjoy!

BirkhoffLee commented 7 years ago

Docker containers are meant to be running only ONE service per container. You should not do that as it will break maintainability, flexibility and make stuff go more complex. Something you should do is to use multiple containers and link them together. Docker Compose is a good thing to try.