search

nimmis / docker-spigot

A docker container with spigot, builds spigot.jar on first start
175 stars 82 forks source link

Build spigot jar in docker build as opposed to docker run #2

Closed Hout closed 9 years ago

Hout commented 9 years ago

With the risk of labouring the obvious: the nature of a docker image is that it is build in the docker build command and run with the docker run command. Building the jar in the spigot_init shell script in docker run is against the nature of docker and will confuse people.

Including the build of the spigot.jar in a separate image build simplifies updating the jar.

nimmis commented 9 years ago

It has to do with license. You are not allowed to redistribute the jar file which is done by downloading Minecrafts version, decompile it and the patch it and the recompile it. So I can't include the precompile version in the container. The script check to see if you already have a compiled version som it won't do it each time you start.

nimmis commented 9 years ago

Updated the README with information why the precompiled version can't be distributed with the image

Hout commented 9 years ago

Aha! Thx again :+1: