nimmis / docker-spigot

A docker container with spigot, builds spigot.jar on first start
177 stars 81 forks source link

Add UTF-8 support and several changes #44

Closed penut85420 closed 3 years ago

penut85420 commented 3 years ago

Thanks to this work to let me build my server more easily, and I learn a lot from this repo! I found that the UTF-8 character is not working under this image, and it is not friendly for server localization. After some research, I found a solution to address this issue. So I add these to Dockerfile, and my plugins and commands with UTF-8 character finally work.

I add environment variable $OTHER_JAVA_OPS to let the user decide what options they want to add, such as gc collection.

due to the output.con will be deleted when mc_restart, mc_log will be not working, add -F option to tail.

I think that showing the logs after mc_send is unnecessary since they can simply do it by mc_send && mc_log, and without mc_log following by mc_send, the user can even write a script to run commands on the host.

Thanks for your work again!

mmraz commented 3 years ago

I merged this PR and the other outstanding PRs into my fork. mmraz/docker-spigot if you want to work with something that's being maintained.