nimmis / docker-spigot

A docker container with spigot, builds spigot.jar on first start
177 stars 81 forks source link

wrong version on older spigot version (>1.12) #69

Open orkeilius opened 2 months ago

orkeilius commented 2 months ago

the container download java 11 instead of 8 or 7 on older version

console error

...
OpenJDK Runtime Environment Temurin-11.0.13+8 (build 11.0.13+8)
OpenJDK 64-Bit Server VM Temurin-11.0.13+8 (build 11.0.13+8, mixed mode)
Attempting to build version: '1.8.8' use --rev <version> to override
Found version
{
        "name": "582a",
        "description": "Jenkins build 582a (hotfix 2)",
        "refs": {
                "BuildData": "838b40587fa7a68a130b75252959bc8a3481d94f",
                "Bukkit": "01d1820664a5f881665b84b28871dadd132deaef",
                "CraftBukkit": "741a1bdf3db8c4d5237407df2872d9857427bfaf",
                "Spigot": "21fe7077d9140e0f9db01587a39c2ffec29e3ec8"
        }
}

*** The version you have requested to build requires Java versions between [Java 7, Java 8], but you are using Java 11
*** Please rerun BuildTools using an appropriate Java version. For obvious reasons outdated MC versions do not support Java versions that did not exist at their release.
cp: cannot stat '/build-mc/spigot-*.jar': No such file or directory
ls: cannot access '//minecraft/spigot.jar': No such file or directory
BUILD FAILED: spigot version 1.8.8 failed (continue running version ) 
...

potential solution (not tested)

the set_mc_ver file set java 11 for older version, it should do more check to use to correct version of java on old version

orkeilius commented 2 months ago

Seem to bug up to minecraft 1.12 (included)