Closed nimplay closed 2 years ago
In this PR I:
Hi, I fix all the requirements. How is the submit process?
El jue, 26 may 2022 a las 15:15, Omar Muhammad @.***>) escribió:
@.**** commented on this pull request. Changes Required ♻️ Hi @nimplay https://github.com/nimplay,
Nice job, you are almost there. ⚠️Please open this pull request again and implement the required changes below⚠️
https://camo.githubusercontent.com/56bcd754643682fcc078b66eaa7278dead6c9c5013595c875b4ddcbe0f0ef0aa/68747470733a2f2f6d65646961302e67697068792e636f6d2f6d656469612f78554f786668365a4d373565664d3342716f2f67697068792d646f776e73697a65642d6d656469756d2e676966 (Highlights) Good Points: 👍
- You documented your work professionally. ✔
- Github flow is used correctly. ✔
- All linters checks are ok. ✔
(Changes Required) Aspects to improve: ♻️
- Please check the inline comments below.
[Optional] suggestions:
- Nothing to mention.
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear, and please remember to tag me in your question so I can receive the notification**
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy https://microverse.zendesk.com/hc/en-us/articles/1500004088561 you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form https://airtable.com/shrQAqnBwek5a0O0s.
In index.html https://github.com/nimplay/Microverse_Portfolio/pull/1#discussion_r882974173 :
Nimrod Acosta
- Please add the site logo inside an tag instead of
tag and remove the wrapping
tag for semantic reasons.
In index.html https://github.com/nimplay/Microverse_Portfolio/pull/1#discussion_r882977566 :
- Please add your hamburger button inside a
- Please remove this background image from here (HTML file) and add it as background-image property in your style sheet style.css for semantic reasons. You can use this link https://www.w3schools.com/cssref/pr_background-image.aspto know more about it and this link https://www.w3schools.com/cssref/pr_background-position.asp to know how to position it.
— Reply to this email directly, view it on GitHub https://github.com/nimplay/Microverse_Portfolio/pull/1#pullrequestreview-986649374, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMPHFNMHAMMLLCGQHDGQINTVL7EVPANCNFSM5W7CVC3Q . You are receiving this because you were mentioned.Message ID: @.***>
Hi @nimplay,
I don't see any commits pushed to this branch.
Please Reopen this pull request and push all changes to the same branch which is portfolioV1
then ask for a review with this Pull Request link.
Hello bro other reviewer said that I had to change the name of PR and brand and in this process the last PR is deleted. I had to call directly to microverse for change the data and add the new Branch and the last one the net PR was accepted. I don't know how to proceed in this case.
El jue., 26 de mayo de 2022 19:43, Omar Muhammad @.***> escribió:
Hi @nimplay https://github.com/nimplay, I don't see any commits pushed to this branch. Please Reopen this pull request and push all changes to the same branch which is portfolioV1 then ask for a review with this Pull Request link.
— Reply to this email directly, view it on GitHub https://github.com/nimplay/Microverse_Portfolio/pull/1#issuecomment-1139147706, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMPHFNNCUKQJLIBSJVE4I7DVMAECPANCNFSM5W7CVC3Q . You are receiving this because you were mentioned.Message ID: @.***>
If you need some kind of proof about your review I don't know if a capture screen of these mail can help you sorry for the setbacks
El vie., 27 de mayo de 2022 08:00, nimrod acosta @.***> escribió:
Hello bro other reviewer said that I had to change the name of PR and brand and in this process the last PR is deleted. I had to call directly to microverse for change the data and add the new Branch and the last one the net PR was accepted. I don't know how to proceed in this case.
El jue., 26 de mayo de 2022 19:43, Omar Muhammad @.***> escribió:
Hi @nimplay https://github.com/nimplay, I don't see any commits pushed to this branch. Please Reopen this pull request and push all changes to the same branch which is portfolioV1 then ask for a review with this Pull Request link.
— Reply to this email directly, view it on GitHub https://github.com/nimplay/Microverse_Portfolio/pull/1#issuecomment-1139147706, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMPHFNNCUKQJLIBSJVE4I7DVMAECPANCNFSM5W7CVC3Q . You are receiving this because you were mentioned.Message ID: @.***>
check linters