nimplay / Microverse_Portfolio

Website programmed using HTML CSS Javascript, for the educational purpose into the microverse course
4 stars 0 forks source link

Setup and Mobile skeleton #1

Closed nimplay closed 2 years ago

nimplay commented 2 years ago

check linters

nimplay commented 2 years ago

In this PR I:

nimplay commented 2 years ago

Hi, I fix all the requirements. How is the submit process?

El jue, 26 may 2022 a las 15:15, Omar Muhammad @.***>) escribió:

@.**** commented on this pull request. Changes Required ♻️ Hi @nimplay https://github.com/nimplay,

Nice job, you are almost there. ⚠️Please open this pull request again and implement the required changes below⚠️

https://camo.githubusercontent.com/56bcd754643682fcc078b66eaa7278dead6c9c5013595c875b4ddcbe0f0ef0aa/68747470733a2f2f6d65646961302e67697068792e636f6d2f6d656469612f78554f786668365a4d373565664d3342716f2f67697068792d646f776e73697a65642d6d656469756d2e676966 (Highlights) Good Points: 👍

  • You documented your work professionally. ✔
  • Github flow is used correctly. ✔
  • All linters checks are ok. ✔

(Changes Required) Aspects to improve: ♻️

  • Please check the inline comments below.

[Optional] suggestions:

  • Nothing to mention.

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear, and please remember to tag me in your question so I can receive the notification**

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy https://microverse.zendesk.com/hc/en-us/articles/1500004088561 you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form https://airtable.com/shrQAqnBwek5a0O0s.

In index.html https://github.com/nimplay/Microverse_Portfolio/pull/1#discussion_r882974173 :

  • Nimrod Acosta


In index.html https://github.com/nimplay/Microverse_Portfolio/pull/1#discussion_r882977566 :


  • In index.html https://github.com/nimplay/Microverse_Portfolio/pull/1#discussion_r882981176 :