search

nimroddolev / chime_tts

A custom Home Assistant integration to play combined audio files before and/or after text-to-speech (TTS) messages
https://nimroddolev.github.io/chime_tts/
MIT License
147 stars 12 forks source link

Latest Update ignores volume setting when announce is set true #154

Closed andyfrei closed 20 hours ago

andyfrei commented 6 days ago

System Health details

System Information

version core-2024.6.4
installation_type Home Assistant OS
dev false
hassio true
docker true
user root
virtualenv false
python_version 3.12.2
os_name Linux
os_version 6.6.31-haos-raspi
arch aarch64
timezone Europe/Zurich
config_dir /config
Home Assistant Community Store GitHub API | ok -- | -- GitHub Content | ok GitHub Web | ok GitHub API Calls Remaining | 4994 Installed Version | 1.34.0 Stage | running Available Repositories | 1386 Downloaded Repositories | 67
Home Assistant Cloud logged_in | false -- | -- can_reach_cert_server | ok can_reach_cloud_auth | ok can_reach_cloud | ok
Home Assistant Supervisor host_os | Home Assistant OS 12.4 -- | -- update_channel | stable supervisor_version | supervisor-2024.06.0 agent_version | 1.6.0 docker_version | 26.1.4 disk_total | 469.4 GB disk_used | 37.1 GB healthy | true supported | true host_connectivity | true supervisor_connectivity | true ntp_synchronized | true virtualization | board | yellow supervisor_api | ok version_api | ok installed_addons | Advanced SSH & Web Terminal (18.0.0), File editor (5.8.0), Home Assistant Google Drive Backup (0.112.1), Studio Code Server (5.15.0), InfluxDB (5.0.0), Grafana (10.0.0), Samba share (12.3.1), ESPHome (2024.6.1), Mosquitto broker (6.4.1), AirSonos (4.2.1), RTSPtoWeb - WebRTC (1.4.0), UniFi Network Application (3.1.0), ESPresense Companion (0.6.5), MQTT Explorer (browser-1.0.3)
Dashboards dashboards | 5 -- | -- resources | 46 views | 73 mode | storage
Recorder oldest_recorder_run | 10. Juni 2024 um 18:15 -- | -- current_recorder_run | 23. Juni 2024 um 08:53 estimated_db_size | 826.40 MiB database_engine | sqlite database_version | 3.44.2
Sonoff version | 3.7.3 (e240aaf) -- | -- cloud_online | 1 / 1 local_online | 1 / 1
Spotify api_endpoint_reachable | ok -- | --

Checklist

Describe the issue

With the latest update, when announce is set to true and no volume specified (because already handled elsewhere) chime does ignore the current set volume level of the speaker(s) and just "screams" at 100%.

Reproduction steps

  1. call service chime_tts_say: send message with announce false and NO volume level specified

    volume level used is the one which is set on the player at that time

  2. call service chime_tts_say: send message with announce true and NO volume level specified

    volume level currently set gets ignored and announcement gets sent with 100%

Debug logs

see diagnostics dump

Diagnostics dump

home-assistant_chime_tts_2024-06-23T08-44-47.060Z.log

nimroddolev commented 3 days ago

Hi @andyfrei. I'm sorry you've run into this issue and thank you for providing the debug log messages.

I believe I have found and fixed the bug, but seeing as I do not own any Sonos speakers I am unable to verify the fix on actual hardware.

Could you please upgrade to v1.1.4-beta1, and let me know if the issue is resolved for you?

To install the beta version:

  1. Open the Chime TTS repository in HACS.
  2. Click on the ⋮ button in the top right.
  3. Select the ↻ Redownload option.
  4. Enable the Show beta versions option (it may take a moment to update the list).
  5. Select version v1.1.4-beta1 from the updated version drop-down list.
  6. Restart Home Assistant.
andyfrei commented 20 hours ago

Hi nimroddev

Yes, I can confirm that with v1.1.4-beta1 this issue is fixed. Great work!!!

Cheers

From: Nimrod Dolev @.> Sent: Tuesday, June 25, 2024 5:00 PM To: nimroddolev/chime_tts @.> Cc: Andy Frei @.>; Mention @.> Subject: Re: [nimroddolev/chime_tts] Latest Update ignores volume setting when announce is set true (Issue #154)

Hi @andyfrei https://github.com/andyfrei . I'm sorry you've run into this issue and thank you for providing the debug log messages.

I believe I have found and fixed the bug, but seeing as I do not own any Sonos speakers I am unable to verify the fix on actual hardware.

Could you please upgrade to v1.1.4-beta1, and let me know if the issue is resolved for you?

To install the beta version:

  1. Open the Chime TTS repository in HACS https://my.home-assistant.io/redirect/hacs_repository/?owner=nimroddolev&repository=chime_tts&category=integration .
  2. Click on the ⋮ button in the top right.
  3. Select the ↻ Redownload option.
  4. Enable the Show beta versions option (it may take a moment to update the list).
  5. Select version v1.1.4-beta1 from the updated version drop-down list.
  6. Restart Home Assistant.

— Reply to this email directly, view it on GitHub https://github.com/nimroddolev/chime_tts/issues/154#issuecomment-2189194738 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AIKS4EQUXRHBJ3KH5NQ23BDZJGAX3AVCNFSM6AAAAABJYFVT22VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOBZGE4TINZTHA . You are receiving this because you were mentioned. https://github.com/notifications/beacon/AIKS4EVAFVDN2J4TSTCKFKDZJGAX3A5CNFSM6AAAAABJYFVT22WGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTUCPR27E.gif Message ID: @. @.> >

nimroddolev commented 20 hours ago

Glad to hear it! 👍