nimsandu / spicetify-bloom

Spicetify theme inspired by Microsoft's Fluent Design, Always up-to-date!, A Powerful Theme to Calm your Eyes While Listening to Your Favorite Beats
MIT License
562 stars 50 forks source link

Issues + request #220

Closed stpnwf closed 3 months ago

stpnwf commented 1 year ago

These issues can be reproduced on a brand new installation of Spotify + Spicetify + Marketplace with just Bloom installed from the Marketplace. Still loving this Spotify theme. Thanks for it!

Issues:

1. Play and Pause buttons are overlayed onto themselves.
2. Some elements have the same color no matter the color scheme. Nothing in color.ini will affect them
3. Minor issue: there is no blur when clicking the user menu, unlike other dialogs
4. Play bar obstructs what Friends are playing as well as Lyrics
5. Weird glitch when scrolling through sidebar playlists It scrolls fine until it gets about halfway through, then that happens...
6. Liked Songs + Your Episode + New Play list buttons won't remain hidden once Spotify is restarted.

Request

1. Any chance we could get support for custom images to be displayed instead of the folders? Ideally like Dribbblish, but anything similar really. Personally I am not a fan of how they look, and they even look broken on some dark color schemes... like Comfy and Dark Mono
nimsandu commented 1 year ago

@stpnwf thanks for reaching out and providing a well-organized issue. we will do our best to resolve these issues in the near future

SunsetTechuila commented 1 year ago

Play and Pause buttons are overlayed onto themselves Minor issue: there is no blur when clicking the user menu, unlike other dialogs Liked Songs + Your Episode + New Play list buttons won't remain hidden once Spotify is restarted.

Can't reproduce

stpnwf commented 1 year ago

Can't reproduce

I am on Linux, maybe that is it. Tried it on both Fedora 37 and Vanilla OS with Bloom from the marketplace and Spotify installed via Flathub.

Although some of those issues may not be relevant anymore given Spotify's redesign. Unsure if it will influence Bloom's interface going forward.

SunsetTechuila commented 1 year ago

6 is definitely a spicetify issue, not a theme

Raiden0456 commented 1 year ago

Can't reproduce

I am on Linux, maybe that is it. Tried it on both Fedora 37 and Vanilla OS with Bloom from the marketplace and Spotify installed via Flathub.

Although some of those issues may not be relevant anymore given Spotify's redesign. Unsure if it will influence Bloom's interface going forward.

Same here, pause and play buttons overlay each other, this is definitely a linux problem, as i'm running fedora 38 + GNOME

SunsetTechuila commented 1 year ago
  1. Play bar obstructs what Friends are playing

Friends have been fixed in https://github.com/nimsandu/spicetify-bloom/commit/be77059df1c1bfe5f5d7ae0c6ecbdc08c15ebcc2

as well as Lyrics

feature, not a bug

SunsetTechuila commented 1 year ago
  1. Weird glitch when scrolling through sidebar playlists

Fixed in https://github.com/nimsandu/spicetify-bloom/commit/a4ef0b5fc14ba19360624ece033c581efe442014

SunsetTechuila commented 1 year ago
  1. Some elements have the same color no matter the color scheme. Nothing in color.ini will affect them

and more can't be themed: image

SunsetTechuila commented 1 year ago
  1. Some elements have the same color no matter the color scheme. Nothing in color.ini will affect them

fixed completely in https://github.com/nimsandu/spicetify-bloom/commit/eb7b91ad9bad5cc665b1bd203e97f44df1c2b869

SunsetTechuila commented 1 year ago

Any chance we could get support for custom images to be displayed instead of the folders? Ideally like Dribbblish

added in https://github.com/nimsandu/spicetify-bloom/commit/a3b751bd4732f7a1df05d43a67ee671a9961a181

SunsetTechuila commented 1 year ago

Minor issue: there is no blur when clicking the user menu, unlike other dialogs

Can't reproduce

Now I know the reason. As karimawii has in #259 you probably have a menu appears right after the user-widget box element, not at the very end of the body - the result is that all content behind the menu actually is after it in DOM. No content that is a DOM ancestor of the Backdrop Root element should contribute to or affect the Backdrop Root Image.

For the same reason, for example, this menu does not have blurred backdrop: image And this is what happens if we move it to the end of the body: image

SunsetTechuila commented 1 year ago

fixed image

SunsetTechuila commented 1 year ago

@stpnwf are we ready to close the issue?

nice green color scheme you have btw, do you want to make pr with it?

stpnwf commented 1 year ago

Thank you for fixing it! I won't be able to check it until hopefully this weekend, but I will close this issue and open another if there are still issues. Do you have any idea when the updated version will hit Marketplace?

nice green color scheme you have btw, do you want to make pr with it?

Thanks, it is heavily inspired by the Zorin OS Dark Green color scheme. I really love it. If you'd like I can make a PR, but I have never made one before, so I'd have to look up how to do it. LMK These are the colors though:

text=BBF1DD
subtext=6b8a7f
alt-text=6b8a7f
main=1B2421
sidebar=1B2421
player=101411
player-border=33433d
player-bar-shadow=BBF1DD
player-bar-bg=323336
card=101411
shadow=101411
selected-row=33433D
button=28c48b
button-active=00ac6f
button-disabled=33433D
tab-active=33433D
notification=6b8a7f
notification-error=d43353
misc=6b8a7f
not-selected=6b8a7f
accent=BBF1DD
layer-shadow=1B2421
contour=1B2421

Sadly, I don't have a screenshot for it ATM bc I am playing around with a frankeinstein theme rn (in the pic below), but the pic below should have the same feel as the above color scheme.

Screenshot from 2023-05-19 19-07-29-obfuscated

SunsetTechuila commented 1 year ago

Do you have any idea when the updated version will hit Marketplace?

Usually it takes two days

If you'd like

Personally I definitely would

SunsetTechuila commented 1 year ago

but I will close this issue and open another if there are still issues.

It's better not to close current issue until you are sure that all is fixed than to close and open a new one

stpnwf commented 1 year ago

Usually it takes two days

Awesome, then I will check that and file the request on Sunday.

It's better not to close current issue until you are sure that all is fixed than to close and open a new one

Alright, thanks for reopening it.

SunsetTechuila commented 1 year ago

Awesome, then I will check that and file the request on Sunday.

@stpnwf hello, just a quick reminder

stpnwf commented 1 year ago

@stpnwf hello, just a quick reminder

Sorry, I forgot.

Most issues were fixed but I still encountered some:

Screenshot from 2023-06-01 15-54-46

Screenshot from 2023-06-01 15-49-57

Screenshot from 2023-06-01 14-07-25

SunsetTechuila commented 1 year ago

Most issues were fixed but I still encountered some:

I'm waiting for the color scheme first of all)

pic 1

white color was hardcoded by me because of visibility

pic 2

will be fixed

pic 3

what's wrong?

SunsetTechuila commented 1 year ago

Thanks. I'll probably make all the buttons spice-text color

stpnwf commented 1 year ago

I'm waiting for the color scheme first of all)

I am having issues with SSH, will try pushing it once I get it working.

stpnwf commented 1 year ago

I'm waiting for the color scheme first of all)

Here you go!

kernelb00t commented 9 months ago

@stpnwf Are there still any issues?

nimsandu commented 3 months ago

@stpnwf i closed this as this is inactive, be comfortable to reopen anytime if needed! thanks!