search

nimsandu / spicetify-bloom

Spicetify theme inspired by Microsoft's Fluent Design, Always up-to-date!, A Powerful Theme to Calm your Eyes While Listening to Your Favorite Beats
MIT License
539 stars 49 forks source link

theme script migration #241

Closed ohitstom closed 1 year ago

ohitstom commented 1 year ago

This PR is implementing the new theme script feature added in Spicetify v2.17.2.

SunsetTechuila commented 1 year ago

Also need to add bloom.js removal if exist

ohitstom commented 1 year ago

Also need to add bloom.js removal if exist

I can remove it from the config but i dont know how much sense it would make to do anything more since this is an install script and within a few updates mostly new users will be using said script anyways.

SunsetTechuila commented 1 year ago

Thanks for the quick response and contribution! This is the first time I've seen someone not only add a new feature to a parent project, but also independently implement its support in child ones) That deserves respect!

SunsetTechuila commented 1 year ago

@nimsandu please merge my PRs first to avoid conflict

nimsandu commented 1 year ago

@ohitstom @SunsetTechuila all conflicts solved and successfully merged into spicetify-bloom main

nimsandu commented 1 year ago

@ohitstom as sunset mentioned, you deserve our bloom communities' respect for doing such a great job by fixing not just spicetify-cli but also effected themes too.

@ohitstom we respect you for what you have done Mr. Thomas Fitzpatrick