ninadmhatre / byteguide

Solution for hosting your HTML code docs (fork of hostthedocs)
Other
1 stars 3 forks source link

Add flake8 #3

Open ninadmhatre opened 9 months ago

Wesztman commented 5 months ago

@ninadmhatre , I would actually recommend going with "ruff" instead 😊 I've used it with great success in https://github.com/Wesztman/get-py-deps/blob/main/pyproject.toml

image

You can get get the same checks as for flake8, but it's alot quicker. It's kind of the new cool kid in Python town 😜

https://github.com/astral-sh/ruff

You could actually also replace black with ruff-format, they are interchangeable but ruff is alot quicker there also 😊

ninadmhatre commented 5 months ago

I have used ruff, it's fast for sure, lets use ruff instead of black and flake8. I will update this ticket.

Do you use copilot or similar AI tools, I wanted to see how good are they at generating tests.

On Mon, 1 Apr, 2024, 11:10 am Carl Westman, @.***> wrote:

@ninadmhatre https://github.com/ninadmhatre , I would actually recommend going with "ruff" instead 😊 I've used it with great success in https://github.com/Wesztman/get-py-deps/blob/main/pyproject.toml

image.png (view on web) https://github.com/ninadmhatre/byteguide/assets/54413402/76b6d93c-0ce5-404f-8e11-b72a28bbd685

You can get get the same checks as for flake8, but it's alot quicker. It's kind of the new cool kid in Python town 😜

https://github.com/astral-sh/ruff

You could actually also replace black with ruff-format, they are interchangeable but ruff is alot quicker there also 😊

— Reply to this email directly, view it on GitHub https://github.com/ninadmhatre/byteguide/issues/3#issuecomment-2029451911, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAQGZFIGU3RUEDEGP5IH47TY3EQBBAVCNFSM6AAAAABASG5XJGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRZGQ2TCOJRGE . You are receiving this because you were mentioned.Message ID: @.***>

Wesztman commented 5 months ago

I'm a big fan and user of co-pilot, I could see if I can auto-generate a couple of tests 😊👌 it would be nice to have some tests, at least for the basic functionality, so that we don't accidentally break stuff 😅