search

ninapavlich / django-imagekit-cropper

Allow users to manually specify image variant crops
MIT License
22 stars 4 forks source link

Pack for Debian #11

Open fioddor opened 4 years ago

fioddor commented 4 years ago

Would you mind to help packaging django-imagekit-cropper for Debian?

I'm willing to help if someone else supports me in this effort.

I've checked the code and at first sight I found following:

Solving this issue won't immediately guarantee that django-imagekit-cropper will be accepted in Debian. More work might be needed, but our odds there would drastically improve.

Disclaimer: I'm contributor to FreedomBox project and reviewing our list of interesting apps for self-hosting I found GetTogether interesting to work on but it relies on django-imagekit-cropper. Being FreedomBox a pure Debian blend we are self-restricted to provide only Debian software. So packaging django-imagekit-cropper for Debian would be a basic step.

ninapavlich commented 4 years ago

Hello! That sounds like a great idea! Would you be able to set up a PR for these changes?

On Thu, Oct 29, 2020 at 03:58 fioddor notifications@github.com wrote:

Would you mind to help packaging django-imagekit-cropper for Debian?

I'm willing to help if someone else supports me in this effort.

I've checked the code and at first sight I found following:

  • jcrop is currently missing (or at least I couldn't find it) in Debian. I think we could consider it integral part of django-imagekit-cropper. At least for the moment.
  • Debian 11 "Bullseye" currently only ships jquery 3.5.1 and there are reasons for Debian to prohibit its packages to ship each their own copy of the same library. Thus I think django-imagekit-cropper shoould be certify-tested with jquery 3.5.1. If you do that I'll take care of the necessary tweaks for the installation in Debian. It would be awesome if you provide a comprehensive battery of automated unit-test, but just a statement of having manually tested it will suffice.

Solving this issue won't immediately guarantee that django-imagekit-cropper will be accepted in Debian. More work might be needed, but our odds there would drastically improve.

Disclaimer: I'm contributor to FreedomBox project https://freedombox.org and reviewing our list of interesting apps for self-hosting https://wiki.debian.org/FreedomBox/LeavingTheCloud I found GetTogether https://github.com/GetTogetherComm/GetTogether interesting to work on but it relies on django-imagekit-cropper. Being FreedomBox a pure Debian blend https://www.debian.org/blends/ we are self-restricted to provide only Debian software. So packaging django-imagekit-cropper for Debian would be a basic step.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/ninapavlich/django-imagekit-cropper/issues/11, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADD2XRRFQAN5HXS4WDWO2DSNFDFVANCNFSM4TDSD4JQ .

fioddor commented 4 years ago

All I'm asking you to do is TEST with jquery 3.5.1 instead of the provided jqueries (imagekit_cropper/static/imagekit_cropper/js/vendor/jquery.js and imagekit_cropper/static/imagekit_cropper/jcrop/js/jquery.min.js).

I'm NOT asking you to release a version shipping jquery 3.5.1 and its corresponding minified version. If you want to do so it'll be fine but not required.

Now, if you're willing to do so, may I suggest to use the occasion and also update JCrop to a newer version? https://github.com/tapmodo/Jcrop shows 2.0.4 from 2 years ago while django-imagekit-cropper ships v0.9.19. I fear it might have changed too much. In such a case perhaps an intermediate version?

I want to bother you as less as possible but there are maintainability reasons for this (See https://wiki.debian.org/UpstreamGuide). On the other hand we understand that you don't focus on Debian and that's why I don't ask you for changes in your releases. I'll program and document the adaptations inside the Debian package.