search

ninegua / reversi

Multiplayer Reversi Game on Internet Computer
https://ninegua.github.io/reversi
MIT License
66 stars 25 forks source link

Add metascore integration #14

Open jorgenbuilder opened 3 years ago

jorgenbuilder commented 3 years ago

So, we have this project to be a leaderboard hub / aggregator for IC games. This PR integrates the reversi game in Metascore. This is more of a proposal than a ready-to-ship PR: canister ids shouldn't be overwritten in any final PR, and I haven't tested how the upgrade would affect state.

It would be great to get this integration in, so that everyones' existing high scores could make their way into Metascore!

ninegua commented 3 years ago

This is an interesting PR. Thanks!

The changes to deliver scores to Metascore looks a bit invasive to me. Will it be possible to use a pull model instead of push?

Also it seems to rely on a critical assumption "a user has the same principal across multiple games" to make this work. Am I reading it correctly?

jorgenbuilder commented 3 years ago

Yes, we support pull and push. At the moment pulls are very infrequent, so push is just better for being up to date.

Yes common principal across cans is critical. The Stoic wallet provides that in this PR. Metascore also supports plug.

We are currently running this code in our own canisters, which you can see by going to metascore.one

Not sure if it would make sense to merge these changes to your upstream, but wanted to give you a heads up, and would be happy to help get this PR in a better state if you wanted to merge!

On Wed, Sep 22, 2021 at 4:09 PM Paul Liu @.***> wrote:

This is an interesting PR. Thanks!

The changes to deliver scores to Metascore looks a bit invasive to me. Will it be possible to use a pull model instead of push?

Also it seems to rely on a critical assumption "a user has the same principal across multiple games" to make this work. Am I reading it correctly?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ninegua/reversi/pull/14#issuecomment-925392137, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOQ5SUMUNB6ZQTMCGQWF2LDUDJOZTANCNFSM5EFUE2LA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.