Open kshitizsingh opened 10 years ago
nineinchnick
commented
10 years ago Thanks a lot for the input. I'm in the middle of porting changes in the Yii 1 version so I'll probably apply those fixes there first and then try to finish porting the whole set.
As for the focus, do you think it should be disabled or is it needed and I should try to check for any input first?
kshitizsingh
commented
10 years ago Don't double your effort. When you find time do it . Its not stopping anything. Its is just a improvement in usability. Tc.
kshitizsingh
commented
10 years ago remember me option is also not working
nineinchnick
commented
10 years ago I didn't touch it in a month and there have been some BC changes in the core framework. I've got some time now so I'll get back to updating the whole module.
kshitizsingh
commented
10 years ago no problem. I modified you code according to my need and when ever i find some bugs i report to help you guys. Your module is working fine for me after modification. You take your time
nineinchnick
commented
10 years ago Maybe you could create a PR request with your change? Also, I'm the only person working on this and I'm not even using Yii2. I'm quite positively suprised it works for you in the current state.
kshitizsingh
commented
10 years ago not current state. i have to modify the code. what is a PR request?
nineinchnick
commented
10 years ago Basically it means creating a copy of the repository, adding your changes and asking me to include those changes back into my original repository. You'll become a co-author of this module.
Start with this and after reading continue to the description of a pull request.
nineinchnick
commented
9 years ago @kshitizsingh can you make a fork and upload your changes so I could compare them?
Auto focus (username) on login page on usr/login shows error message on user field if user do not fill any entry and try to click on password recovery / registration link. It not allows to click on first time on either of these link and validate the login forms. It is irritating because i have to click twice to go to either (registration / password recovery) of this page.
Also the recovery message says "Don't remember username or password? Go to password recovery." But on the recovery page says recovery for "username or password recovery". "Go to password recovery(link)" message should changed to "Go to recovery."
On Registration / Update Profile / Recovery page verification code is not required field. Error blank message not showing up. Captcha not refresh once submit wrong entry. Might be good with refresh captcha.
On your demo page http://demo2.niix.pl Show error if i click on login using open Id / Login using facebook account.
Comment : I am a newbie to yii2.