Open Kuroneer opened 3 years ago
The only error in the gh actions is
Error: Couldn't produce an instance that satisfies all strict constraints from (cow_http_hd:content_range/0) after 50 tries.
I have tested it successfully both manually with a python client and within cowboy
test suites.
You can run make ct-ws_autobahn
in Cowboy to run full tests related to the protocol. make ct-ws
for the other ones (this is likely where one test would sit for this).
I don't think this is the right fix what it's worth. This setting on the server indicates that the server doesn't want to accept windows larger than a certain size. I believe the correct behavior when that happens is to return ignore
instead.
(force pushed to remove the previous commit from the history and fix the message)
@essen Is there anythin else you'd like to see changed?
I just need to find the time to review and test.
When the client does not provide the "client_max_window_bits" option, the server must reserve the max size.
Currently, if the server provides the option
client_max_window_bits
with something less than 15 and a client does not include the option and uses more than the unknown server value, zlib will fail to inflate the payload.I'll leave this in draft until I'm able to test it.
Are automatic tests for this functionality expected in
cowboy
?