search

ninenines / cowlib

Support library for manipulating Web protocols.
ISC License
281 stars 172 forks source link

Update version to 2.7.3 in Makefile and app file #78

Closed stoshfabricius closed 5 years ago

stoshfabricius commented 5 years ago

Update the Makefile and app file to the new version number to match the version requirements in the new release of cowboy

chulkilee commented 5 years ago

Probably need to yank 2.7.2 and release 2.7.3 ? I don't think it's possible to update existing hex package - since mix.lock has checksum.

chulkilee commented 5 years ago

But I'm surprised it's not caught when uploading to hex. How can a hex package can be uploaded in different version? Probably hex server/client bug? I thought when uploading to hex, it checks the version from code..

stoshfabricius commented 5 years ago

@chulkilee yes that is a good point, I will update to 2.7.3 assuming that this would be a new release.

Also cowboy may need to be updated to reference this new release number since it looks like from the last commit on cowboy it's referencing 2.7.2 directly

essen commented 5 years ago

Merged, thanks! Also added a target to help me release in the future without making mistakes like this.