Fix sending trailers when there are data frames in queue

ninenines / cowlib

Support library for manipulating Web protocols.

ISC License

279 stars 173 forks source link

Fix sending trailers when there are data frames in queue #93

Closed tony612 closed 4 years ago

tony612 commented 4 years ago

Fixes https://github.com/ninenines/cowlib/issues/92. I think this is more reasonable than if (element(1, DataOrFileOrTrailers) =/= trailers) andalso (StreamWindow < MinSendSize) andalso ...

Test case is at https://github.com/ninenines/cowboy/pull/1428

tony612 commented 4 years ago

@essen Could you review this? I have another PR to verify the changes https://github.com/ninenines/cowboy/pull/1432 (Not sure why the tests on arch failed)

essen commented 4 years ago

Patch is fine I'll try to take a look today but I've been sick so let's hope for the best.

essen commented 4 years ago

Merged, thanks!