Crash when http2 server closes connection

ninenines / gun

HTTP/1.1, HTTP/2, Websocket client (and more) for Erlang/OTP.

ISC License

898 stars 231 forks source link

Crash when http2 server closes connection #177

Closed taavi013 closed 5 years ago

taavi013 commented 5 years ago

Just open connection and wait 10+ seconds: gun:open("dns.google.com", 443).

[error] Supervisor gun_sup had child gun started with {gun,start_link,undefined} at <0.923.0> exit with reason no function clause matching gun_http2:parse(<<>>, close) line 106 in context child_terminated

essen commented 5 years ago

I'm currently reworking the HTTP/2 code by merging the Cowboy and Gun code together. If you can send a PR with a test case for this I can make sure to fix it while I do the changes on Gun.

taavi013 commented 5 years ago

Sorry for false alarm, gun from master works. Reopens connection, etc. Was using gun from rebar3 without indicating version.