ninenines / gun

HTTP/1.1, HTTP/2, Websocket client (and more) for Erlang/OTP.
ISC License
891 stars 232 forks source link

HTTP/2: Map the LastStreamID to the reference() in the gun_error message #191

Closed essen closed 4 years ago

essen commented 5 years ago

This would let us know which stream was the last the server started to process.

essen commented 4 years ago

Turns out in the most recent code this is no longer necessary, because Gun will automatically cancel the relevant streams upon receiving a GOAWAY frame. So we only care about streams that are killed when the connection goes down (the streams that are left).

essen commented 4 years ago

I'm removing UnprocessedStreams from the gun_down message. Closing!