search

ninenines / gun

HTTP/1.1, HTTP/2, Websocket client (and more) for Erlang/OTP.
ISC License
891 stars 232 forks source link

Detect HTTP/1 response to HTTP/2 request and return a specific error #217

Closed DmitryKakurin closed 4 years ago

DmitryKakurin commented 4 years ago

Fix for #216 Now the error is: {connection_error, protocol_error, 'HTTP/1 response to HTTP/2 request'}

DmitryKakurin commented 4 years ago

@essen there are build errors, but I don't think they are caused by my fix. Could you take a look, please?

essen commented 4 years ago

Errors are because you have based your branch on 1.3, please base it against master. There's currently no planned 1.x releases unless a customer asks.

DmitryKakurin commented 4 years ago

Sorry, that was me clicking on the wrong link. I've based my fix on 1.3 branch because we are using gun indirectly thru machine_gun, and it requires version 1.3.*. Are you OK with releasing another version off 1.3 branch once I add the check?

essen commented 4 years ago

I'm not doing further 1.3 releases unless a customer requests it.

DmitryKakurin commented 4 years ago

Are we considered a customer :-) ? I mean, we are using gun, and we need a 1.3 release.

essen commented 4 years ago

Paying customer or sponsor.

essen commented 4 years ago

Let's continue on the ticket.