search

ninenines / gun

HTTP/1.1, HTTP/2, Websocket client (and more) for Erlang/OTP.
ISC License
891 stars 232 forks source link

Update to latest erlang.mk #236

Closed lukebakken closed 3 years ago

lukebakken commented 3 years ago

Includes fix from ninenines/erlang.mk#897'

essen commented 3 years ago

RabbitMQ is using Gun somewhere?

lukebakken commented 3 years ago

It is! https://github.com/rabbitmq/rabbitmq-peer-discovery-etcd/blob/master/Makefile

essen commented 3 years ago

OK. Good to know!

But note that master is very far from 1.3.x. I am currently working on the remaining changes before I can release a 2.0 rc but this will take the rest of summer at least because it's quite complex (HTTP/2 CONNECT support). So perhaps the best for you would be that I produce an updated 1.3.x release with the most recent Erlang.mk? Alternatively switch RabbitMQ to the current master, many people are already using it with great success. Depends on the expected timeline for this.

lukebakken commented 3 years ago

I've been working on the convoluted process to get RabbitMQ into VMware's licensing system and noticed this out-of-date file. I'm re-running the process yet again because maybe we don't need this change? I will know more today. Thanks for bringing that point up.

essen commented 3 years ago

Done for master, let me know if needed in older versions. Thanks!