search

ninenines / gun

HTTP/1.1, HTTP/2, Websocket client (and more) for Erlang/OTP.
ISC License
891 stars 232 forks source link

Update to latest erlang.mk #237

Closed lukebakken closed 3 years ago

lukebakken commented 3 years ago

Includes fix from ninenines/erlang.mk#897'

(cherry picked from commit 7f1e77ec1b75f6c63f11243ea4af27c05052c120)

lukebakken commented 3 years ago

Hi @essen - it would be great to get a new 1.3.x release with this change. I'll be opening PRs for new point releases for RabbitMQ to use for other libraries, stay tuned.

essen commented 3 years ago

Can you confirm whether just updating in Gun is enough, or should the older Cowlib version be updated as well? Gun 1.3.x depends on Cowlib 2.6.0, but I suppose RabbitMQ is actually using a more recent version, at least if you have management or Web plugins.

lukebakken commented 3 years ago

Sorry for the delay! Looking at this today.

lukebakken commented 3 years ago

Yep, the rest of RabbitMQ is using cowlib version 2.7.0. This PR is updated.

essen commented 3 years ago

OK I will release the new version tomorrow then.

essen commented 3 years ago

I've merged and pushed so I'm closing this. After confirming this doesn't break anything (who knows) I will push the 1.3.3 tag and ask the Hex package owner to update it.

lukebakken commented 3 years ago

OK as soon as 1.3.3 is pushed I can update RabbitMQ. Thanks!

essen commented 3 years ago

It's published.