fix rebar3 dependency specification

ninenines / gun

HTTP/1.1, HTTP/2, Websocket client (and more) for Erlang/OTP.

ISC License

891 stars 232 forks source link

fix rebar3 dependency specification #238

Closed galdor closed 3 years ago

galdor commented 3 years ago

Rebar3 emits a warning for "raw" git dependency versions, and expects a tuple indicating what the version actually is (a branch, tag or ref).

This warning propagates to any software directly or indirectly using Gun.

essen commented 3 years ago

This file is generated: https://github.com/ninenines/gun/blob/master/Makefile#L49

It's also like this to be compatible with Rebar 2. I don't know if assuming everyone uses Rebar 3 is a good idea. Some people definitely still use Rebar 2. I don't know if Rebar 2 supports this tuple. If it does the fix should be in Erlang.mk.

galdor commented 3 years ago

Rebar3 is now part of the erlang GitHub project. Rebar2 is officially deprecated, there has not been any patch for two years and a half, and the repository has been archived. Of course some people will never upgrade anything, I'm not sure to see the point in supporting them.

In any case, Rebar2 supports this notation.

Anyway I just open a new PR which updates erlang.mk.

essen commented 3 years ago

OK then, please just send the patch to the right location. You can confirm it works by running make check c=core-compat as well.