Error case_clause in gun:connecting/3

ninenines / gun

HTTP/1.1, HTTP/2, Websocket client (and more) for Erlang/OTP.

ISC License

891 stars 232 forks source link

Error case_clause in gun:connecting/3 #253

Closed zuiderkwast closed 3 years ago

zuiderkwast commented 3 years ago

When I run the test suites on current master, I get a {case_clause, {ok, #Port<0.16>}} error in gun:connecting/3 (gun.erl, line 1061).

It happens in the test case event_SUITE:tls_handshake_end_error_tls_connect_tls/1. The guards prevent matching because the local variable Transport is gun_tls_proxy. The guards here are expecting it to be either gun_tcp or gun_tls.

essen commented 3 years ago

Yes I know. There's a todo in the disconnect function.

zuiderkwast commented 3 years ago

Ah, didn't see that.

essen commented 3 years ago

This is important to fix for 2.0 but not for 2.0.0-rc.1 so I will probably skip it for now.

essen commented 3 years ago

I've fixed it. There's still some crashes in event_SUITE though but they're covered by #248 (lack of error handling). I'll see if I can fix it.

essen commented 3 years ago

For future reference the other issue in event_SUITE is a bug in Cowboy: https://github.com/ninenines/cowboy/issues/1479