ninenines / gun

HTTP/1.1, HTTP/2, Websocket client (and more) for Erlang/OTP.
ISC License
891 stars 232 forks source link

Make many gun_http2 functions return state or error tuple #301

Closed zuiderkwast closed 1 year ago

zuiderkwast commented 1 year ago

The following functions used to return a state, but now return {state, State} or {error, Reason}:


This is incremental refactoring preparing for #243

zuiderkwast commented 1 year ago

Good morning Loïc. Are you busy?

I believe when this is merged, the remaining "handle send errors" will be a very small change.

essen commented 1 year ago

Sounds good. Yes if I don't get to this today it will be next Monday.

zuiderkwast commented 1 year ago

OK, great. The change is large but trivial, so I hope it is easy to review.

Then, I can help finishing the remaining 2.0 projects, if you know what you want with them. :-)

essen commented 1 year ago

@zuiderkwast Reviewed. There's at least one error and a couple consistency problems that should easily be resolved.

essen commented 1 year ago

Merged, thanks! I've also fixed the TLS tests that fail. Dialyzer will fail until the other PR is merged.