Add doc and tests for ws sub-protocol negotiation

ninenines / gun

HTTP/1.1, HTTP/2, Websocket client (and more) for Erlang/OTP.

ISC License

891 stars 232 forks source link

Add doc and tests for ws sub-protocol negotiation #305

Closed zuiderkwast closed 1 year ago

zuiderkwast commented 1 year ago

Fixes #284

essen commented 1 year ago

Merged the tests and the missing () but the docs required a lot more changes. Thanks!

zuiderkwast commented 1 year ago

Great! I didn't know how the subprotocol modules work anyway so it's good you did that. Perhaps I helped you get started. :D

essen commented 1 year ago

I mostly struggled to find a good module name for the behavior because gun_ws already refers to the message in the documentation. I'll try to review the last 2.0 PR tomorrow and then release next Monday.