voluntas
commented
1 year ago I'm encountering an error when setting up a local HTTP/2 server written in Go, setting a root CA only on the server side for mTLS, and then attempting to run it.
1> Uri = #{scheme := Scheme, host := Host, path := Path} = uri_string:parse(<<"https://localhost:48080/test">>).
#{port => 48080,scheme => <<"https">>,path => <<"/test">>,
host => <<"localhost">>}
2> Transport = tls.
tls
3> Port = 48080.
48080
4> Hostname = binary_to_list(Host).
"localhost"
5> application:ensure_all_started(gun).
{ok,[cowlib,gun]}
6> TlsOpts = [{versions, ['tlsv1.3', 'tlsv1.2']}, {verify, verify_none}, {server_name_indication, Hostname}].
[{versions,['tlsv1.3','tlsv1.2']},
{verify,verify_none},
{server_name_indication,"localhost"}]
7> {ok, ConnPid} = gun:open(Hostname, Port, #{transport => Transport, protocols => [http2], tls_opts => TlsOpts}).
{ok,<0.203.0>}
8> =NOTICE REPORT==== 22-May-2023::23:03:53.704607 ===
TLS client: In state connection received SERVER ALERT: Fatal - Bad Certificate
=ERROR REPORT==== 22-May-2023::23:03:53.713149 ===
** State machine <0.203.0> terminating
** Last event = {internal,
{connected,
{sslsocket,
{gen_tcp,#Port<0.9>,tls_connection,undefined},
[<0.211.0>,<0.210.0>]},
http2}}
** When server state = {connected,
{state,<0.188.0>,
{up,#Ref<0.4004690427.1749286913.204625>},
"localhost",48080,<<"https">>,"localhost",
48080,[],
#{protocols => [http2],
tls_opts =>
[{versions,['tlsv1.3','tlsv1.2']},
{verify,verify_none},
{server_name_indication,"localhost"}],
transport => tls},
undefined,undefined,gun_tls,true,
{ssl,ssl_closed,ssl_error},
undefined,undefined,undefined,
gun_default_event_h,undefined}}
** Reason for termination = error:{'module could not be loaded',undefined}
** Callback modules = [gun]
** Callback mode = state_functions
** Stacktrace =
** [{gun,disconnect,2,
[{file,"/Users/voluntas/src/erlang/gun/src/gun.erl"},{line,1742}]},
{gen_statem,loop_state_callback,11,[{file,"gen_statem.erl"},{line,1377}]},
{proc_lib,init_p_do_apply,3,[{file,"proc_lib.erl"},{line,241}]}]
=CRASH REPORT==== 22-May-2023::23:03:53.713306 ===
crasher:
initial call: gun:init/1
pid: <0.203.0>
registered_name: []
exception error: undefined function undefined:close/4
in function gun:disconnect/2 (/Users/voluntas/src/erlang/gun/src/gun.erl, line 1742)
in call from gen_statem:loop_state_callback/11 (gen_statem.erl, line 1377)
ancestors: [gun_conns_sup,gun_sup,<0.197.0>]
message_queue_len: 0
messages: []
links: [<0.199.0>]
dictionary: []
trap_exit: false
status: running
heap_size: 10958
stack_size: 28
reductions: 26180
neighbours:
=SUPERVISOR REPORT==== 22-May-2023::23:03:53.714281 ===
supervisor: {local,gun_conns_sup}
errorContext: child_terminated
reason: {undef,[{undefined,close,
[{error,closed},
undefined,gun_default_event_h,undefined],
[]},
{gun,disconnect,2,
[{file,"/Users/voluntas/src/erlang/gun/src/gun.erl"},
{line,1742}]},
{gen_statem,loop_state_callback,11,
[{file,"gen_statem.erl"},{line,1377}]},
{proc_lib,init_p_do_apply,3,
[{file,"proc_lib.erl"},{line,241}]}]}
offender: [{pid,<0.203.0>},
{id,gun},
{mfargs,{gun,start_link,undefined}},
{restart_type,temporary},
{significant,false},
{shutdown,5000},
{child_type,worker}]
essen
I have been encountering a crash during termination when I try to connect to a server that requires mTLS via HTTP/2.
When using HTTP/2 to connect, if the server requires mTLS, it appears to fail at Protocol:init in this section, leaving protocol as undefined and proceeding to the disconnect step: https://github.com/ninenines/gun/blob/master/src/gun.erl#L1259-L1263
Following this, in the disconnect step, it attempts to call undefined:close, which ultimately leads to a crash: https://github.com/ninenines/gun/blob/master/src/gun.erl#L1742
As I'm not sure how to properly address this, I decided to start by creating an issue here.