search

ninenines / ranch

Socket acceptor pool for TCP protocols.
ISC License
1.19k stars 336 forks source link

Obfuscate private key password in logs #334

Closed juhlig closed 10 months ago

juhlig commented 2 years ago

Closes #333

juhlig commented 2 years ago

Hm... the upgrade suite fails. I'll look into that later, it is probably because 2.1 is now the current version or something :\

essen commented 2 years ago

Sounds good.

juhlig commented 2 years ago

I rebased this PR on #338, and the test pass now for all OTP versions except 25-rc3, where it fails in connection with SSL all over the place. Regardless of this PR, I think this is something that needs to be investigated soon as OTP 25 is just around the corner.

essen commented 2 years ago

Where do you see SSL problems? Looking at the Arch Linux logs for example the problem is that Relx is not compatible with OTP 25 and I have fixed that in an Erlang.mk branch (for now) and have patches locally for Ranch and Cowboy. So don't worry about it I will merge all that in order when OTP 25 is released.

juhlig commented 2 years ago

Where do you see SSL problems?

In Ubuntu, MacOS, Debian, Alpine. All tests there pass, until they get to 25-rc3, where 9 in the acceptors suite and 6 in the proxy header suite fail like this:

{error, {tls_alert, {handshake_failure, "TLS client: In state hello received SERVER ALERT: Fatal - Handshake Failure\n"}}}
essen commented 2 years ago

I see. It has to do with certificate verification on the client side. Probably doesn't like the self-signed certificate. Not sure why it wouldn't fail on Arch Linux.

essen commented 1 year ago

Hello! Please rebase and let's ignore the expected macOS failure for now.

juhlig commented 11 months ago

Sorry, this totally fell between the cracks XD Rebased.

juhlig commented 11 months ago

Looks like the buildkite CI is down?

essen commented 11 months ago

You've used all of the job minutes included in your Free plan for this month. To continue running your builds, select a different Buildkite plan.

Welp. But I have a complimentary account.

Might be a good time to move to Actions instead of BuildKite.

essen commented 10 months ago

There's some flaky tests it seems but master is using Actions now, so please rebase so your PR can go through CI. Thanks!

juhlig commented 10 months ago

Done. In 26.1.2 on MacOS the upgrade suite fails, but I don't know what the problem could be. Timeout in os:get_data it says, seems unrelated to this PR.

essen commented 10 months ago

I think it's a flake I've seen it while preparing actions.

essen commented 10 months ago

Merged, thanks!