Multiply RSS usage on OS X to bytes

niner / inline-python-pm

Inline::Python - Write Perl subs and classes in Python.

https://metacpan.org/release/Inline-Python

20 stars 13 forks source link

Multiply RSS usage on OS X to bytes #15

Closed pypt closed 8 years ago

pypt commented 8 years ago

Hi Neil (Neil, right?),

In 4e4879154c329790e965ba85adbcd8e89666b4be, Proc::ProcessTable is reporting RSS usage in bytes on Linux and kilobytes on OS X, so the memory usage was being tested incorrectly. This commit fixes that.

niner commented 8 years ago

It's Stefan actually. Neil wrote Inline::Python and maintained it up until version 0.22. I took over in 2008.

pypt commented 7 years ago

Sorry Stefan! And thanks!

Would you be able to run another quick make dist with a version bump? The fix from #13 (that got into 0.51) is fine, but the unit tests are failing because this PR with a test fix didn't get into 0.51 (and thus is breaking our Travis build).

niner commented 7 years ago

If I had known that it would be this easy! I had planned to look at the odd test failures I got from CPAN testers after the London Perl Workshop. If I had known that that was exactly the failure, your commit had already fixed, I'd have done a release much sooner. Well, 0.52 is on its way to CPAN now :)

pypt commented 7 years ago

Thanks a lot, appreciate it!