niner / inline-python-pm

Inline::Python - Write Perl subs and classes in Python.
https://metacpan.org/release/Inline-Python
20 stars 13 forks source link

Fix build on Windows with recent Python versions #30

Closed Yaribz closed 1 year ago

Yaribz commented 3 years ago
Yaribz commented 1 year ago

I close this 2 years old pull request as it seems there is no interest in it, I will just continue using my own fork on Windows.

niner commented 1 year ago

Oh, sorry, I just forgot about it. I probably didn't have time to review it immediately and then the email was no longer unread and it became one of the 20K old mails in my inbox. Obviously my work management sucks...

Yaribz commented 1 year ago

Thanks but actually most of the changes included in this PR can no longer be applied like this, due to the revamps that occurred in the makefile one year after. I would revert this merge because it goes against the new logic of detecting the python version first to build a fixed library name instead of scanning the dir... (see the $version variable which is built but never used in the special_get_libpath function after this merge...).