nineteendo / comment-rulers

GNU Affero General Public License v3.0
1 stars 0 forks source link

Rounding errors can cause rulers to be misplaced #3

Open nineteendo opened 1 year ago

nineteendo commented 1 year ago

Rounding errors can cause the rulers to be a few pixels misplaced: ruler_misplacement

nineteendo commented 1 year ago

Fixed.

nineteendo commented 1 year ago

Still not fully fixed (but more consistent): image

zachpoblete commented 2 months ago

Any plans to fix this? This is the one bug keeping me from further using it.

Awesome work, though! This is a one-of-a-kind extension.

nineteendo commented 2 months ago

There isn't much I can do about this, as VS Code doesn't provide a great API. I'm using a hack to get the rulers in place.

zachpoblete commented 2 months ago

VS Code doesn't provide a great API.

Darn, that's a bit ironic. But I did realize that this bug isn't actually a deal-breaker for me.

nineteendo commented 2 months ago

Would you prefer the text of long comments to be highlighted or underlined? Or only add a ruler for those? Then it wouldn't get misplaced.

zachpoblete commented 2 months ago

Do you mean like this?

image

The idea is to underline and italicize any text that goes over 80 characters. I achieved this look by editing a git commit message subject line which normally looks like this:

image

This approach seems much simpler and more stable than generating rulers.

Edit: Actually, I just realized most comments are italicized already. Just underlining as you mentioned would still work, and I would prefer that. So this is the look I want:

image

nineteendo commented 2 months ago

I think a red error squiggle might stand out more. And they would show up in problems.

zachpoblete commented 2 months ago

Hmm, yes, that does sound better.