search

ninetwozero / gradle-to-js

A quick & dirty Gradle build file to JavaScript object parser
Apache License 2.0
47 stars 21 forks source link

Add support for IF statements without braces #12

Closed karllindmark closed 6 years ago

karllindmark commented 6 years ago

Helpfully brought to our attention in #10, we didn't previously support IF statements without braces, meaning:

if (condition) key "value"

or even

if (condition)
    key "value"

This should now work a bit better. @JPeer264, could you take a look at this and see if it seems like I'm doing the right thing?

...one thing's certain - I wouldn't have wanted to write this change without having the current test cases as my partner in crime... the VS Code debugger gets an honorable mention as well. :-)

JPeer264 commented 6 years ago

@karllindmark thanks! I just checked it out, it works 👍 I am not getting the last not sentence tho - sorry.

karllindmark commented 6 years ago

Perfect! We've been down with a stomach bug all weekend but I'll get on merging and publishing a new version ASAP.

On Sun, Mar 18, 2018, 20:48 Jan Peer Stöcklmair notifications@github.com wrote:

@karllindmark https://github.com/karllindmark thanks! I just checked it out, it works 👍 I am not getting the last not sentence tho - sorry.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ninetwozero/gradle-to-js/pull/12#issuecomment-374038126, or mute the thread https://github.com/notifications/unsubscribe-auth/AA7w0BwnYdUPdyGi3AgdyjeKG_j18B9pks5tfroRgaJpZM4Sug40 .

JPeer264 commented 6 years ago

Ah, alright I get it now. Thanks for your hard work :)