search

ninetwozero / gradle-to-js

A quick & dirty Gradle build file to JavaScript object parser
Apache License 2.0
47 stars 21 forks source link

Updates loadash.merge to latest version #26

Closed owenniblock closed 5 years ago

owenniblock commented 5 years ago

Motivation

We'd like this released so we can update our dependency in another project :)

npm test runs all pass.

karllindmark commented 5 years ago

Hi Owen!

Thank you for your contribution!

One minor thing - could you please adjust the commit slightly and freeze (is that the correct term?) the version?

Best regards, Karl Lindmark

On Mon, 15 Jul 2019, 21:22 Owen Niblock, notifications@github.com wrote:

Motivation

We'd like this released so we can update our dependency in another project :)

npm test runs all pass.

You can view, comment on, or merge this pull request online at:

https://github.com/ninetwozero/gradle-to-js/pull/26 Commit Summary

  • Updates loadash.merge to latest version

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/ninetwozero/gradle-to-js/pull/26?email_source=notifications&email_token=AAHPBUDNAX7SR2S2G2MTIEDP7TE6HA5CNFSM4IDZ7SCKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4G7JTDNQ, or mute the thread https://github.com/notifications/unsubscribe-auth/AAHPBUDNKVJZSL65Y77KLODP7TE6HANCNFSM4IDZ7SCA .

owenniblock commented 5 years ago

Done! :)

karllindmark commented 5 years ago

Thanks a bunch - will merge it shortly!

Now that my vacation has started I might have time to squeeze #25 in too before releasing. 😀

On Mon, 15 Jul 2019, 22:06 Owen Niblock, notifications@github.com wrote:

Done! :)

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/ninetwozero/gradle-to-js/pull/26?email_source=notifications&email_token=AAHPBUGRPJS4LM5OE5HO6GTP7TKEXA5CNFSM4IDZ7SCKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZ62A4Y#issuecomment-511549555, or mute the thread https://github.com/notifications/unsubscribe-auth/AAHPBUCCL6RX72M3FKTOJWLP7TKEXANCNFSM4IDZ7SCA .

owenniblock commented 5 years ago

Thanks @karllindmark - if there's any chance of a quick release we'd really appreciate it (the update is due to a vulnerability in lodash that was announced recently so we're trying to get all our deps updated)!

owenniblock commented 5 years ago

Just for completeness :) https://github.com/lodash/lodash/issues/4348

karllindmark commented 5 years ago

Done deal, I just put up 2.0.0 (new major version due to me playing around with \r and the plugins closure) - shouldn't be noticable unless you actually relied on the previous (non-)handling of plugins, but if that's the case... then you're probably going to be a lot happier anyways. :-)

owenniblock commented 5 years ago

Amazing! Thanks :)