ninetwozero / gradle-to-js

A quick & dirty Gradle build file to JavaScript object parser
Apache License 2.0
47 stars 21 forks source link

Plugins with hyphen symbol in name are not parsed correctly #35

Closed kurochenko closed 2 years ago

kurochenko commented 2 years ago

The following snippet of code is not parsed correctly:

plugins {
    id 'application-conventions'
    id 'com.google.gms.google-services'
    id 'com.google.firebase.crashlytics'
}

current result is:

 "plugins": [
      {}
      {}
      { "id": "com.google.firebase.crashlytics" }

expected is

 "plugins": [
      { "id": "application-conventions" }
      { "id": "com.google.gms.google-services" }
      { "id": "com.google.firebase.crashlytics" }

By looking into code it seems that regexp for parsing plugin lines does not support hyphen.

karllindmark commented 2 years ago

This should be fixed in 2.0.1, just released! Thanks for the help @kurochenko :-)